FIX: Summary update fixing a bug for TapInteraction#2308
Merged
josepmariapujol-unity merged 1 commit intodevelopfrom Jan 12, 2026
Merged
FIX: Summary update fixing a bug for TapInteraction#2308josepmariapujol-unity merged 1 commit intodevelopfrom
josepmariapujol-unity merged 1 commit intodevelopfrom
Conversation
The interaction requires the control to be released within the timeout (the code uses <= durationOrDefault and cancels on timer expiry), so the comment should say "at most" / "within".
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2308 +/- ##
========================================
Coverage 77.95% 77.95%
========================================
Files 476 476
Lines 97443 97443
========================================
Hits 75961 75961
Misses 21482 21482 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
josepmariapujol-unity
changed the title
josepmariapujol-unity
deleted the
input/docatt-10042/tap-interaction-summary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The interaction requires the control to be released within the timeout (the code uses <= durationOrDefault and cancels on timer expiry), so the comment should say "at most" / "within".
JIRA: DOCATT-10042
Testing status & QA
N/A
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Review carefully.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.